Skip to content

Add logit, logistic_sigmoid, and use in logistic dist to support promotion policies #1297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 23 commits into from
Aug 14, 2025
Merged

Add logit, logistic_sigmoid, and use in logistic dist to support promotion policies #1297

merged 23 commits into from
Aug 14, 2025

Conversation

mborland
Copy link
Member

Closes: #1294
Closes: #1296

@mborland mborland mentioned this pull request Aug 12, 2025
Closed
jzmaddock
jzmaddock reviewed Aug 12, 2025
View reviewed changes
jzmaddock
jzmaddock reviewed Aug 12, 2025
View reviewed changes
@jzmaddock
Copy link
Collaborator

Thanks for this Matt!

@codecov Codecov
Copy link

codecov bot commented Aug 12, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.07%. Comparing base (4d7d6e1) to head (f87d826).
⚠️ Report is 28 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1297      +/-   ##
===========================================
+ Coverage    91.51%   95.07%   +3.55%     
===========================================
  Files          558      796     +238     
  Lines        53881    67020   +13139     
===========================================
+ Hits         49311    63717   +14406     
+ Misses        4570     3303    -1267
Files with missing lines Coverage Δ
include/boost/math/distributions/logistic.hpp 80.25% <100.00%> (-0.96%) ⬇️
include/boost/math/policies/policy.hpp 95.83% <ø> (-4.17%) ⬇️
.../boost/math/special_functions/logistic_sigmoid.hpp 100.00% <100.00%> (ø)
include/boost/math/special_functions/logit.hpp 100.00% <100.00%> (ø)
test/math_unit_test.hpp 22.95% <100.00%> (ø)
test/test_logistic_sigmoid.cpp 100.00% <100.00%> (ø)
test/test_logit.cpp 100.00% <100.00%> (ø)

... and 336 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d7d6e1...f87d826. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

WarrenWeckesser
WarrenWeckesser reviewed Aug 12, 2025
View reviewed changes
Copy link
Contributor

@WarrenWeckesser WarrenWeckesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was fast!

I have a question below about using the promoted type with the location/scale calculations that occur outside of the calls of logit or logistic_sigmoid.

Also a couple minor nitpicks involving minus signs.

WarrenWeckesser
WarrenWeckesser reviewed Aug 12, 2025
View reviewed changes
@mborland mborland merged commit 483f36c into develop Aug 14, 2025
64 checks passed
@mborland mborland deleted the 1296 branch August 14, 2025 12:09
@WarrenWeckesser
Copy link
Contributor

Thanks @mborland!

@mborland
Copy link
Member Author

Thanks @mborland!

You're welcome! Since I have some time I'm looking through the other distributions to see where else we need to apply manual promotion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jzmaddock jzmaddock jzmaddock left review comments

+1 more reviewer

@WarrenWeckesser WarrenWeckesser WarrenWeckesser left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proposed update for the quantile function of the logistic distribution. Double promotion for the logistic quantile doesn't work?
3 participants
@mborland @jzmaddock @WarrenWeckesser